Fix domain derivation on LC syncAggregate validation#5252
Merged
Conversation
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
reviewed
Mar 9, 2023
| const signingRoot = ssz.phase0.SigningData.hashTreeRoot({ | ||
| objectRoot: ssz.phase0.BeaconBlockHeader.hashTreeRoot(update.attestedHeader.beacon), | ||
| domain: store.config.getDomain(update.signatureSlot, DOMAIN_SYNC_COMMITTEE), | ||
| domain: store.config.getDomain(update.signatureSlot - 1, DOMAIN_SYNC_COMMITTEE), |
Contributor
There was a problem hiding this comment.
or should we use attestedHeader.beacon.slot?
Contributor
There was a problem hiding this comment.
ahh just checked the linked PR , lgtm 👍
Contributor
There was a problem hiding this comment.
sadly, attested_header.beacon.slot may be incorrect.
Example:
BELLATRIX_FORK_EPOCH = 0
CAPELLA_FORK_EPOCH = 255
DENEB_FORK_EPOCH = 256
attested_header.slot = 8159 (bellatrix)
signature_slot = 8192 (Deneb)
fork_version_slot = 8191 (Capella)
so, sync committee would be determined by sync committee at slot 8192, the fork version is determined by slot 8191, and the object is from slot 8159
Contributor
There was a problem hiding this comment.
thanks @etan-status for the insightful example 🙏 ❤️
g11tech
approved these changes
Mar 9, 2023
Member
|
🎉 This PR is included in v1.7.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Fix off by one error causing invalid signature errors on fork boundary